-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reference comparison #218
Conversation
I am not sure how you generate the README examples, should I just manually copy the comments from the implementation to README.md @astorije? |
@jakubzitny Will |
Yes, it's already in the test cases: https://github.com/astorije/chai-immutable/pull/218/files#diff-c1129c8b045390789fa8ff62f2c6b4a9. The |
Yup, it's a very complex build step that involves copying and pasting 😅 |
b1abcc7
to
bfd8eec
Compare
@jakubzitny, I took the liberty to add the doc in the README, and also renaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your help!! 🙏
Changes are OK. The commit messages could be better, but that's your call 😉 I can squash the |
Heh, that's fine for this one. |
This has now be released as part of v2.1.0. Thanks again! |
Implement reference comparison
This MR adds
referenceEqual
BDD method andreferenceEqual
andreferenceNotEqual
TDD methods according to the discussion in #210.Close #210.